-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(dotnet/logs): add Logs for the .NET SDK #14583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Oh it's draft, sorry I might have jumped the gun tagging @AbhiPrasad and @cleptric here |
Bundle ReportChanges will increase total bundle size by 2.19kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Co-authored-by: Abhijeet Prasad <[email protected]>
title: Set Up Logs | ||
sidebar_title: Logs | ||
description: "Structured logs allow you to send, view and query logs sent from your applications within Sentry." | ||
sidebar_order: 5600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: order
We're inconsistent with the order for SDKs that have both Crons
and Logs
Logs
beforeCrons
: Go, PHPCrons
beforeLogs
: Java, Python, Ruby
Where should we put it?
Does it matter?
@AbhiPrasad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not worry about this for now, I'll just merge what we have here.
I raised a thread in slack to chat more about this: https://sentry.slack.com/archives/C081M1KEQ0L/p1754917568834039. Once we make a decision there, I'll leave another comment here about what we are going to change. I'll own fixing the order here.
<PlatformSection supported={["dotnet.aspnetcore, dotnet.azure-functions-worker, dotnet.blazor-webassembly, dotnet.extensions-logging, dotnet.maui"]}> | ||
|
||
Additionally, when enabled and initialized, the SDK registers a [ILoggerProvider](https://learn.microsoft.com/dotnet/api/microsoft.extensions.logging.iloggerprovider) | ||
that allows sending logs to Sentry via [ILogger<T>](https://learn.microsoft.com/dotnet/api/microsoft.extensions.logging.ilogger-1) instances resolved through _.NET dependency injection_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: <
and >
are not supported within link text and will fail the include to parse/render
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES